Refactor Empirical distribution #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 93.70% 93.80% +0.10%
==========================================
Files 53 53
Lines 11939 12002 +63
==========================================
+ Hits 11187 11259 +72
+ Misses 752 743 -9 ☔ View full report in Codecov by Sentry. |
The old code always removed entries and re-inserted them if necessary. The new code will instead modify the value (= data_point count) in-place and only remove the key- value pair from the map if the count would've dropped to zero.
FreezyLemon
force-pushed
the
refactor-empirical
branch
from
ee7245d
to
35bce3e
Compare
No value of `Infallible` can ever exist, so it is statically proven that `Result<Empirical, Infallible>` can never exist as a `Result::Err` variant. This allows layout optimizations and is arguably a clearer API.
|
Pushed a breaking change on top of the previous ones. |
|
It looks good, and the tests were definitely needed for the statistics. Thank you, I appreciate what you do. |
YeungOnion
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing here should be breaking. Some of the changes are opinionated code quality improvements.
Two noticeable improvements from this:
Option<(f64, f64)>is larger than twof64s. Up to 8 bytes on x64)BTreeMap::removeinsidefn removeif value > 1Probably also removes a branch in
fn add, but I honestly haven't checked the generated ASM or checked via benchmarking. Should I?